Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken links in Notebooks #3878

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Fixed broken links in Notebooks #3878

merged 3 commits into from
Sep 27, 2024

Conversation

varodrig
Copy link
Contributor

@varodrig varodrig commented Sep 24, 2024 •
edited
Loading

fixes #3810

@varodrig
Issue kubeflow#3810
4fce8da 
Signed-off-by: varodrig <[email protected]>
@google-oss-prow Google OSS Prow
Copy link

Hi @varodrig. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hbelmiro
hbelmiro reviewed Sep 24, 2024
View reviewed changes
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@varodrig can you please just do the following?

@google-oss-prow google-oss-prow bot added the lgtm label Sep 24, 2024
@hbelmiro hbelmiro mentioned this pull request Sep 24, 2024
Open
6 tasks
@hbelmiro
Copy link
Contributor

/ok-to-test

@varodrig varodrig changed the title Issue #3810 Fixed broken links in Notebooks Sep 24, 2024
@varodrig varodrig marked this pull request as ready for review September 24, 2024 13:13
@varodrig
Copy link
Contributor Author

/lgtm

@varodrig can you please just do the following?

Done. thank you for reviewing.

@hbelmiro
Copy link
Contributor

@thesuperzapper can you please take a look?

@varodrig varodrig mentioned this pull request Sep 24, 2024
Closed
@thesuperzapper
Copy link
Member

@hbelmiro @varodrig looks fine to me, but I can't approve it because we need a root approver to be able to edit the Netlify configs.

/lgtm

@thesuperzapper
Copy link
Member

@andreyvelich can you please approve this fix on the website, we need a root approver.

@andreyvelich
Copy link
Member

/lgtm
/approve

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 888c2da into kubeflow:master Sep 27, 2024
6 checks passed
This was referenced Oct 10, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbelmiro hbelmiro hbelmiro left review comments

@james-jwu james-jwu Awaiting requested review from james-jwu

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

@gaocegege gaocegege Awaiting requested review from gaocegege

@rimolive rimolive Awaiting requested review from rimolive

@StefanoFioravanzo StefanoFioravanzo Awaiting requested review from StefanoFioravanzo

Assignees

@thesuperzapper thesuperzapper

@hbelmiro hbelmiro

@andreyvelich andreyvelich

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix broken links in Notebooks
4 participants
@varodrig @hbelmiro @thesuperzapper @andreyvelich